[Freeciv-Dev] Re: (PR#4310) Rulesetdir civ2 and gtk2 client

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

--On Wednesday, July 09, 2003 20:33:26 -0700 Vasco Alexandre da Silva Costa 
<vasc@xxxxxxxxxxxxxx> wrote:

>
> On Wed, 9 Jul 2003, Jason Short wrote:
>
>> [ms209290@xxxxxxxxxxxxxxxxxxx - Tue May 27 09:13:13 2003]:
>>
>> > When I use rulesestdir civ2, the gtk2 client prints:
>> >
>> > 2: Don't have graphics tags - or - for impr_type Airport
>> > 2: Don't have graphics tags - or - for impr_type Aqueduct
>> > 2: Don't have graphics tags - or - for impr_type Bank
>> > 2: Don't have graphics tags - or - for impr_type Barracks
>> > 2: Don't have graphics tags - or - for impr_type Barracks II
>> > 2: Don't have graphics tags - or - for impr_type Barracks III
>> > ...
>> > ...
>> >
>> > and crashes
>>
>> The warnings are normal, but obviously the crash is bad.  I can't
>> reproduce this with gui-gtk.  Can you get a backtrace?
>
> This is because the GTK+ 2.0 client uses improvement graphics in the
> city window. GTK+ 1.2 does not.

The warnings are generated by the common code, and will happen regardless.

> Yes the crash is bad. I will have to find a way to handle missing
> graphics more gracefully.

Yeah; just check for a NULL pointer.

jason