[Freeciv-Dev] (PR#4351) Client crashes when diplomat/spy investigates city

["Cameron Morland" <cameron@xxxxxxxxxx>]

Hi,

When I try to investigate an enemy city using a spy, the client crashes.
To duplicate, login as "cjmorlan", then move the spy near Zgorzelec into
the city. Click "investigate city".

civclient: unittype.c:86: get_unit_type: Assertion `id >= 0 && id < 200
&& id < game.num_unit_types' failed.

Program received signal SIGABRT, Aborted.
0x402bea51 in kill () from /lib/libc.so.6
(gdb) bt  
#0  0x402bea51 in kill () from /lib/libc.so.6
#1  0x402be872 in raise () from /lib/libc.so.6
#2  0x402bf986 in abort () from /lib/libc.so.6
#3  0x402b8ae9 in __assert_fail () from /lib/libc.so.6
#4  0x080cca9a in get_unit_type (id=0) at unittype.c:88
#5  0x0807961e in fill_unit_sprite_array (sprs=0xbffff7c4, punit=0x82c8808, 
    solid_bg=0x0) at tilespec.c:1387
#6  0x0809c97a in put_unit_gpixmap (punit=0x82c8808, p=0x8371a48)
    at mapview.c:931
#7  0x08080d12 in city_dialog_update_supported_units (pdialog=0x8370a90)
    at citydlg.c:2057
#8  0x0807c71a in refresh_city_dialog (pcity=0x8365cb8) at citydlg.c:423
#9  0x0807f9fa in create_city_dialog (pcity=0x8365cb8, make_modal=false)
    at citydlg.c:1600
#10 0x0807c959 in popup_city_dialog (pcity=0x8365cb8, make_modal=false)
    at citydlg.c:486
#11 0x08072060 in handle_city_packet_common (pcity=0x8365cb8, is_new=false, 
    popup=true) at packhand.c:513
#12 0x08071d4e in handle_city_info (packet=0x83707f0) at packhand.c:459
#13 0x08065eb5 in handle_packet_input (packet=0x83707f0, type=0)
    at civclient.c:309
#14 0x08068d4e in input_from_server (fd=10) at clinet.c:330
#15 0x401550aa in gdk_get_show_events () from /usr/lib/libgdk-1.2.so.0
#16 0x40183ac6 in g_io_add_watch () from /usr/lib/libglib-1.2.so.0
#17 0x401850b1 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#18 0x40185568 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#19 0x40185798 in g_main_run () from /usr/lib/libglib-1.2.so.0
#20 0x400a67f7 in gtk_main () from /usr/lib/libgtk-1.2.so.0
#21 0x08095536 in ui_main (argc=1, argv=0xbffffc54) at gui_main.c:952
#22 0x080659c6 in main (argc=1, argv=0xbffffc54) at civclient.c:238

spycrash.sav.gz
Description: spycrash.sav.gz