[Freeciv-Dev] Re: (PR#4202) No more allied-allied-war v2

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Fri, 30 May 2003, Gregory Berkolaiko wrote:
> 1. when we hit "accept treaty" button, you patch checks if we are at war
> with one of the opponent's allies.I think it's more logical to check if
> the opponent is at war with our allies, since it's our obligation to
> ensure we are not making love with a common enemy.

Well, sure. It it not like it makes a big (or any) difference.

> 2. I think you can easily avoid the goto repeat_cancel_treaty by using
> do { } while(repeat);Don't forget to add
> } else {
> repeat = FALSE;
> }
> though.

But I like goto. It reminds me of my sins of youth as an unrepentant basic
programmer ;-)

I'll look at it.

  - Per