Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2003:
[Freeciv-Dev] Re: (PR#4202) No more allied-allied-war v2

[Freeciv-Dev] Re: (PR#4202) No more allied-allied-war v2

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: a-l@xxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4202) No more allied-allied-war v2
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Fri, 30 May 2003 05:17:39 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Fri, 30 May 2003, Gregory Berkolaiko wrote:
> 1. when we hit "accept treaty" button, you patch checks if we are at war
> with one of the opponent's allies.I think it's more logical to check if
> the opponent is at war with our allies, since it's our obligation to
> ensure we are not making love with a common enemy.

Well, sure. It it not like it makes a big (or any) difference.

> 2. I think you can easily avoid the goto repeat_cancel_treaty by using
> do { } while(repeat);Don't forget to add
> } else {
> repeat = FALSE;
> }
> though.

But I like goto. It reminds me of my sins of youth as an unrepentant basic
programmer ;-)

I'll look at it.

  - Per

[Prev in Thread] Current Thread [Next in Thread]