[Freeciv-Dev] (PR#4145) Combat and move points.

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Right now if a land unit is attacked and it's HP is decreased, it's MP are 
left unaffected.  So we have a situation when a unit has more move-points 
than would be given to it by unit_move_rate (which does take into account 
HPs and such).

As far as I can see, the same is true about attacking units: they lose 
only SINGLE_MOVE points however low their new health might be.  This is of 
course only applicable to Armour, all other units have less then 2 moves.

Ah distinctly I remember that in Civ II when I used to blast cities with 
my howitzers they risked losing all 2 of their moves in one attack.  This 
seems not to be the case in Freeciv either.

I think we need to change the system.  I feel what is now done for ships 
(unithand.c around line 720) is very just and suitable for land units too.

But whatever system is adopted, I think moves_left should _always_ be
capped by unit_move_rate.

Best wishes,
G.

P.S. See PR#2513 for a related patch already applied to ships.