Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2003:
[Freeciv-Dev] Re: (PR#3745) Diplomacy patch part 2
Home

[Freeciv-Dev] Re: (PR#3745) Diplomacy patch part 2

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3745) Diplomacy patch part 2
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Wed, 30 Apr 2003 14:16:02 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Thu, 24 Apr 2003, Per I. Mathisen wrote:

> On Sun, 20 Apr 2003, Gregory Berkolaiko wrote:
> > > These are necessary changes for the next installment of this series of
> > > patches, since it creates a more general framework to handle various
> > > types of treaties and their cancellation.
> >
> > The patch looks sane to me.Should it be ported to other clients first?  It
> > will break them as it is now.
> 
> Here it is, ported to all clients.

Committed, fixing this:

-    pa.value = player_index;
-    send_packet_generic_integer(&aconnection, 
PACKET_PLAYER_REMOVE_VISION,
-                               &pa);
+    packet.id = player_index;
+    packet.value1 = CLAUSE_VISION;
+    send_packet_generic_values(&aconnection, PACKET_PLAYER_CANCEL_PACT,
+                              &pa);

The last pa should be packet (only noticed when it refused to compile).

G.





[Prev in Thread] Current Thread [Next in Thread]