[Freeciv-Dev] (PR#4048) Update Economy Dlg. after tax rates change.

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

[bursig - Mon Apr 21 17:43:40 2003]:

> Hi
> 
> This patch allow update of economy report dlg. after player info 
> package come. It is usefull when you have open economy dlg., and change 
> tax rates (to see the result). I need this functionality becouse I 
> merge tax rates dlg. with economy report dlg. in SDLClient but I think 
> that this will be usefull to other clients.

This is definitely good, but I don't think we should *always* update the
economy dialog.  We should track a boolean value like popuptech, and
check the incoming values to see if anything has changed that causes the
update to be required.  For starters, we can just check for changed tax
rates.

> This code fix some problems under server side that server should update 
> cities (send cities infos) first and then send player info to client 
> (client must have correct city info to calculate tax income).
> Patch swap seqence of sending cities and player infos to client after 
> change tax rates.

This seems good in principle, but I'm not too familiar with this code.

jason