[Freeciv-Dev] Re: (PR#3745) Diplomacy patch part 2

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Quoting "Per I. Mathisen" <per@xxxxxxxxxxx>:

> 
> This part does some internal generalization and simplification of the
> diplomatic network traffic and handling.
> 
> What it does:
> - PACKET_PLAYER_REMOVE_VISION has been removed
> - PACKET_PLAYER_CANCEL_PACT now takes a value that indicates what kind of
> treaty is being cancelled, which may be CLAUSE_VISION
> - New function establish_embassy(), which wraps embassy making
> 
> These are necessary changes for the next installment of this series of
> patches, since it creates a more general framework to handle various
> types of treaties and their cancellation.

The patch looks sane to me.  Should it be ported to other clients first?  It
will break them as it is now.

In the comment /* Anything but VISION */ you should probably explain that all
other values will be interpreted as break the ceasefire/peace/alliance pact.

G.