[Freeciv-Dev] Re: (PR#3899) [PATCH] Add generator which simulates plate tectonics

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

> He very kindly gave me this permission, so I have modified his code
> to compile cleanly in FreeCiv; the code is from 1988 and still has
> its K&R-style function arguments.
> 
> This patch is designed to be applied after applying Josh Cogliati's patch
> (http://rt.freeciv.org/Ticket/Display.html?id=3489) which adds a sixth 
> map generator to freeciv.
> 
> To use this patch, simply set the generator to 7 (which will generate
> pure tectonic shift maps) or 8 (which will generate hybrid maps: Maps
> which are tectonically generated maps with filtered noise added so that
> the oceans have more islands to explore).
> 
> Note that this code takes far longer to generate maps than the other
> generators; on the other hand, the lands generated are far more realistic,
> especially for larger maps.
 
I haven't examined this in detail, but remove the Rnd function and use
freeciv's myrand. also please review doc/CodingStyle. The note that some
maps took ~5 minutes to generate is quite disconcerting. Please give us
some statistics. over a range of initial conditions, what is the average
drawing time? If the answer is larger than anywhere on the order of half a
minute, there is no possibility that the code will be accepted. In this
case, some approximations must be made. 

Also, please post somewhere a couple of screenshots (or upload some to the
ftp server). Also send us a savegame or two that demonstrates the
generator.

-mike