Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2003:
[Freeciv-Dev] Re: (PR#3781) Micro size of structs optimizations
Home

[Freeciv-Dev] Re: (PR#3781) Micro size of structs optimizations

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bursig@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3781) Micro size of structs optimizations
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 24 Mar 2003 09:49:49 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, Mar 24, 2003 at 09:44:03AM -0800, Per I. Mathisen wrote:
> 
> On Mon, 24 Mar 2003, Rafa³ Bursig wrote:
> > Attached patch almost don't change structs only sort variables. I
> > change some types city.h to show that we can reduce size of game
> > structs even more ( sizeof(struct city) : before 2128,after 2028 )
> 
> But is this really faster? Have you measured this?
> 
> While the patch may seem innocent enough, it breaks a lot of patches and
> introduces sorting of variables in structs by optimization rather than
> logic, which is not good for code readability reasons.

I tend to agree, and 100bytes or so isn't enough to convince me 

-mike



[Prev in Thread] Current Thread [Next in Thread]