Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2003:
[Freeciv-Dev] Re: (PR#3480) New Buffer Code

[Freeciv-Dev] Re: (PR#3480) New Buffer Code

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: bursig@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3480) New Buffer Code
From: "Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>
Date: Wed, 19 Feb 2003 13:27:00 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Wed, Feb 19, 2003 at 11:14:52AM -0800, Rafa³ Bursig wrote:
> This code is big with lot of changes ( touch almost entire SDLClient)
> Some change :
> - new buffer system.
> - partial support for waste in city dlg. ( no place for waste string )
> - animated unit sellector ( replace blinking unit )
> - porting new dlg options ( dont ask for city name and don't open city 
> dlg for new cities)
> - default Civ3 city desc. text.
> - fix network connection check.
> - support for meta servers.
> - fix for sellect races dlg.
> - lot of fix and cleans.

The subject is clearly misleading. This patch is a huge monster.

The patch contains little gems like:

-  Uint16 *__pTmp_str = NULL;
+  Uint16 *___pTmp_str = NULL;

3 underscores are better than two?! Btw: it is bad to use variables
with leading underscores at all (these are reserved by the C standard
for internal use).

There are the expected style problems like this:

+  if (pFind_City_Dlg) return;

It contains code added in comments:
+      /*add_refresh_rect(pWindow->size);*/
       pWindow->size.x += Main.event.motion.xrel;

Basically the patch is a mess. There is now way in hell people can
look over this 14k line patch. Maybe this was intended. The patch has
more the state of a diff between working tree and the CVS. No cleanup
was done.


 email: rf13@xxxxxxxxxxxxxxxxx
  Two OS engineers facing a petri net chart:
        "dead lock in four moves!"

[Prev in Thread] Current Thread [Next in Thread]