[Freeciv-Dev] (PR#2963) Unlimited recursion

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

During an auto-game I got a server with a stack trace like this:
#0  0x0807650a in airspace_looks_safe (x=73, y=37, pplayer=0x814df80)
    at gotohand.c:1455
#1  0x08076668 in air_can_move_between (moves=14, src_x=79, src_y=34, 
    dest_x=69, dest_y=37, pplayer=0x814df80) at gotohand.c:1525
#2  0x0809dc2e in refuel_iterate_process (rp_list=0x8450e60, pfrom=0x841323c)
    at airgoto.c:468
#3  0x0809dddd in find_air_first_destination (punit=0x8450e60, 
    dest_x=0xbfa87198, dest_y=0xbfa87194) at airgoto.c:570
#4  0x0807602d in do_unit_goto (punit=0xe, restriction=GOTO_MOVE_ANY, 
    trigger_special_ability=false) at gotohand.c:1291
#5  0x080ce532 in ai_unit_goto (punit=0x8424ce8, x=1076528712, y=1076528712)
    at aitools.c:172
#6  0x080c9a9e in ai_manage_airunit (pplayer=0x12, punit=0xa) at aiair.c:345
#7  0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#8  0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#9  0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#10 0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#11 0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#12 0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#13 0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#14 0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364
#15 0x080c9b2c in ai_manage_airunit (pplayer=0x814df80, punit=0x8424ce8)
    at aiair.c:364

It will get into this state after saving civgame+1957.sav.gz. However
the can't be recreated by loading civgame+1957.sav.gz or
civgame+1947.sav.gz. So I attached the script to recreate the problem.

        Raimar

--
 email: rf13@xxxxxxxxxxxxxxxxx
  Tank: So what do you need? Besides a miracle.
  Neo: Guns. Lots of guns.
    -- From The Matrix

set randseed 42       # repeat a particular game (random) sequence
set seed 42           # repeat a particular map generation sequence
set timeout -1          # run a server only autogame
set aifill 7            # fill to 7 players
set researchcost 4
#set endyear 1200
hard                    # make the AI do complex things
create Caesar           # first player (with known name) created and 
                        # toggled to AI mode
start