[Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patc
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Fri, Jan 31, 2003 at 05:01:17AM -0800, esr@xxxxxxxxxxx via RT wrote:
>
> I must be missing something. I reread the style guide without finding
> anything that looked relevant to this line.
the relevant line is:
- spaces are inserted before and after operators (instead of
"int a,b,c;" use "int i, j, k;" and instead of "if(foo<=bar) c=a+b;"
use "if (foo <= bar) c = a + b;" -- note the space between "if"
so: for(i = 0; i < num_sprite_dirs; i++)
old code doesn't follow this, but if code gets touched, it should be
reformatted.
also your new includes probably should be protected by ifdefs from
config.h
-mike
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, (continued)
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, Jordi Mallach, 2003/01/31
- Message not available
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, Jordi Mallach via RT, 2003/01/31
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, Eric S. Raymond, 2003/01/31
- Message not available
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, esr@xxxxxxxxxxx via RT, 2003/01/31
- Message not available
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, esr@xxxxxxxxxxx via RT, 2003/01/31
- Message not available
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch, esr@xxxxxxxxxxx via RT, 2003/01/31
- [Freeciv-Dev] Re: (PR#2922) Revised version of data-reorganizattion patch,
Mike Kaufman via RT <=
|
|