[Freeciv-Dev] (PR#2565) Plural form needed for unit types

["Guest via RT" <rt@xxxxxxxxxxxxxx>]

Raimar Falke via RT <rt@xxxxxxxxxxxxxx>:
> And the patch. 
> 
> Erik: last chance to object.

I take that chance.


> -      notify_player(pplayer, _("Game: %d %s upgraded to %s for %d
gold."),
> -                    number_of_upgraded_units,
unit_types[from_unittype].name,
> -                    unit_types[to_unittype].name,
> -                    cost * number_of_upgraded_units);
> +      notify_player(pplayer,
> +     PL_("Game: %d unit of %s upgraded to %s for %d gold.",
> + "Game: %d units of %s upgraded to %s for %d gold.",
> + number_of_upgraded_units), number_of_upgraded_units,
> +     unit_types[from_unittype].name,
> +     unit_types[to_unittype].name,
> +     cost * number_of_upgraded_units);

This produces messages like
"Game: 1 unit of legion upgraded to ..."
"Game: 1 unit of carrier upgraded to ..."

The fundamental problem is that some units have names that belong to a
component of that unit ("settling unit"/"settler"). This needs to be
handled in 1 of 2 ways.
1. Change the unit names so that they all refer to the whole unit, not
to a component. For example change "settler" to something like "settling
unit", "colonizing group", "settling team", ....
2. Make the ruleset indicate wether the unit name refers to the whole
unit or a component. Change all code that produces messages about units
to have 2 versions. For example "Game: %d %s upgraded to %s for %d
gold."/"Game: %d units of %s upgraded to %s for %d gold."

I prefer the 1st way. And I would like plural forms for unit types. I
don't think the upgrade message should be changed before those issues
have been fixed.