[Freeciv-Dev] Re: (PR#2641) islands from the client's point of view

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Mon, Dec 23, 2002 at 06:16:47PM -0800, Mike Kaufman via RT wrote:
> 
> here is a patch to make the server define a continent from a client's point
> of view. This requires that we add a continent field to the player_tile and
> call map_get_continent and map_set_continent with a player parameter. This
> causes a slight complication in that these two functions have been moved
> out of common/ into both client/ and server/
> 
> The behavior of map_[set|get]_continent in the server is that
> ptile->continent is referenced if the function is called with pplayer==NULL
> otherwise plrtile->continent is referenced. The client always references
> ptile->continent and ignores the value of pplayer.
> 
> On a side note, I've moved the map functions in climisc.c into a new
> climap.c (which I'd wanted to do for a while). With the addition of the
> continent functions, it seemed reasonable. I've also reworked the continent
> updaters in the client to follow the server's way of doing things. This
> means that now continents are numbered sequentially with no gaps. This does
> add a bit of overhead when two different continents are found to be the
> same continent, as it is possible that a third continent will have to be
> renumbered to fill in the gap left by the second... read

> recycle_continent_num() for more details. The advantages would be that it
> would be cleaner for agents, for example, to do calculations on continents.

Why?

> I consider this ready to go into CVS. My own testing hasn't revealed any
> problems if the default ruleset is used. There might be some problems if

Have you tested PR#2223? The patch should fix the issue.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Microsoft does have a year 2000 problem. I'm part of it. I'm running Linux.