[Freeciv-Dev] Re: (PR#2533) unification of move_unit_map_canvas

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Wed, Dec 18, 2002 at 11:03:17AM -0800, Jason Short via RT wrote:
> On Wed, 2002-12-18 at 05:01, Raimar Falke via RT wrote:
> > On Tue, Dec 17, 2002 at 04:28:34PM -0800, Jason Short via RT wrote:
> > > On Tue, 2002-12-17 at 14:19, Raimar Falke via RT wrote:
> > > > On Tue, Dec 10, 2002 at 02:12:47AM -0800, Jason Short via RT wrote:
> 
> > > > The patch ok except one thing: what is the propose of
> > > > single_tile_pixmap_width? Why was it added? Why do you use it?
> > > 
> > > single_tile_pixmap_width/single_tile_pixmap_height are currently used as
> > > the width and height of the single_tile_pixmap pixmap (which is a
> > > secondary backing store used only for animations).  But these are always
> > > UNIT_TILE_WIDTH/UNIT_TILE_HEIGHT, so there's not much reason for their
> > > existence.
> > 
> > So I replace their usage in the patch with
> > UNIT_TILE_WIDTH/UNIT_TILE_HEIGHT.
> 
> This is confusing!  They should either be used consistently or removed.

Removed. Done with the patch (common code builds sprite of the unit)
you outline in the previous mail

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python 2.0 beta 1 is now available [...]. There is a long list of new 
  features since Python 1.6, released earlier today. We don't plan on 
  any new releases in the next 24 hours."
    -- Jeremy Hylton at Slashdot