Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2575) define CITY_TILES in city.h
Home

[Freeciv-Dev] Re: (PR#2575) define CITY_TILES in city.h

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: kayeats@xxxxxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2575) define CITY_TILES in city.h
From: "Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>
Date: Wed, 18 Dec 2002 05:54:27 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Wed, Dec 18, 2002 at 01:30:44PM +0000, Gregory Berkolaiko wrote:
> I located another use for this define.
> 
> In client/agents/cma_core.c there is 
> #define MAX_FIELDS_USED         (CITY_MAP_SIZE * CITY_MAP_SIZE - 4 - 1)

I know ;)

> which is actually only used as (MAX_FIELDS_USED + 1).
> 
> There are following options: 
> 1. MAX_FIELDS_USED + 1 is substituted with CITY_TILES throughtout 
> cma_core.c and the define is removed
> 2. MAX_FIELDS_USED is left where it is, but the define is changed to 
> #define MAX_FIELDS_USED         (CITY_TILES - 1)

> Raimar, which you would prefer.

2.

> In general, when I know Raimar's opinion, I intend to commit the
> patch straight away.  So speak up or forever be silent.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Living on earth may be expensive, but it includes an annual free trip
  around the sun.




[Prev in Thread] Current Thread [Next in Thread]