Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2471) Message bug: stolen tech
Home

[Freeciv-Dev] Re: (PR#2471) Message bug: stolen tech

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Christian Knoke <chrisk@xxxxxxxx>
Subject: [Freeciv-Dev] Re: (PR#2471) Message bug: stolen tech
From: "ChrisK@xxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>
Date: Wed, 11 Dec 2002 01:39:06 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, Dec 02, 2002 at 12:38:25PM -0800, ChrisK@xxxxxxxx via RT wrote:
> On Mon, Dec 02, 2002 at 11:04:15AM -0800, Per I. Mathisen via RT wrote:
> > 
> > On Sun, 1 Dec 2002, Guest via RT wrote:
> > > 1.14beta CVS 01 DEC 2002 Gtk 1.2
> > >
> > > When a tech is stolen from us (by means of conquering one of our cities,
> > > a message is given about the stolen tech in the _chat_window_, but
> > > not in the messages window (F10) nor in an individual window, even
> > > if theappropriate message option is set.
> > >
> > > For testing use ki-testb.sav.gz in incoming
> > 
> > Found it. But it is in a generic function used by both diplomats and city
> > conquest, so I guess there is no "appropriate message option" to use...
> 
> I'd thought, "Enemy Diplomat: Theft" is appropriate.

Patch attached.

> > A proper solution here will involve another event type, which is outside
> > the scope of a 1.14.0 fix.
> > 
> >   - Per

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

diff -Nur -Xdiff_ignore ../../cvs/beta/freeciv/server/plrhand.c 
./server/plrhand.c
--- ../../cvs/beta/freeciv/server/plrhand.c     Sat Dec  7 21:14:49 2002
+++ ./server/plrhand.c  Wed Dec 11 09:58:45 2002
@@ -606,9 +606,10 @@
                   get_tech_name(pplayer, i),
                   get_nation_name_plural(target->nation));
 
-  notify_player(target, _("Game: The %s stole %s from you!"),
-               get_nation_name_plural(pplayer->nation),
-               get_tech_name(pplayer, i));
+  notify_player_ex(target, -1, -1, E_ENEMY_DIPLOMAT_THEFT,
+                   _("Game: The %s stole %s from you!"),
+                  get_nation_name_plural(pplayer->nation),
+                  get_tech_name(pplayer, i));
 
   notify_embassies(pplayer, target,
                   _("Game: The %s have stolen %s from the %s."),

[Prev in Thread] Current Thread [Next in Thread]