[Freeciv-Dev] Re: (PR#2472) Allies with dead players in player report

["Per I. Mathisen via RT" <rt@xxxxxxxxxxxxxx>]

On Sun, 1 Dec 2002, Guest via RT wrote:
> 1.14beta CVS 01 DEC 2002 Gtk 1.2
>
> When you are allied with someone, who is later killed by another player,
> it is still possible to Cancel Treaty with that player, with
> the consequence, that your reputation goes down.

Well, that sort of makes sense. Even if you denounce your ally after he is
dead, people will look at you and frown ;)

> It is also possible to clickon Withdraw Vision forever, without
> a result.

This is not good. It should be easily fixed, however:

Index: maphand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/maphand.c,v
retrieving revision 1.111
diff -u -r1.111 maphand.c
--- maphand.c   14 Nov 2002 09:15:04 -0000      1.111
+++ maphand.c   2 Dec 2002 19:25:08 -0000
@@ -1247,8 +1247,7 @@
     return;
   }
   pplayer2 = get_player(packet->value);
-  if (pplayer == pplayer2 || !pplayer2->is_alive
-      || !gives_shared_vision(pplayer, pplayer2)) {
+  if (pplayer == pplayer2 || !gives_shared_vision(pplayer, pplayer2)) {
     return;
   }

Not tested. If people agree this should be changed, I'll test it and
commit.

  - Per