[Freeciv-Dev] Re: compiling the SDL client

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Dec 04, 2002 at 02:35:20PM -0500, Jason Short wrote:
> On Wed, 2002-12-04 at 06:22, Raimar Falke wrote:
> > On Wed, Dec 04, 2002 at 02:54:09AM -0500, Jason Short wrote:
> > > The SDL client is now in CVS.  Some administrative issues are still
> > > being resolved, but right now it can be compiled and tested.  However,
> > > you'll need the attached patch to do it.  You will also need to copy the
> > > entire contents of the data/theme directory from the freeciv-test
> > > module.  For directions on that, go to http://freeciv-test.sf.net/.
> > > 
> > > It should be noted that many features are not implemented, and many of
> > > the ones that are only work incompletely.  It should also be noted that
> > > the attached patch makes many simple fixes, but also has a few
> > > significant hacks to work around incompatible parts of the code.
> > 
> > > +/* This ordering is hard-coded in the tilespec files. */
> > 
> > This just isn't true. The numbers are hardcoded between the caller of
> > get_citizen_sprite and this code in
> > client/tilespec.c:tilespec_lookup_sprite_tags()
> > 
> >   /* This uses internal code for citizens array/index: */
> >   SET_SPRITE(citizen[0], "citizen.entertainer");
> >   SET_SPRITE(citizen[1], "citizen.scientist");
> > ...  
> >   SET_SPRITE(citizen[10], "citizen.angry_1");
> 
> Ahh, I see.  I'd like to provide the enum and its uses as a separate
> patch, which will help in cleaning up this code in gui-sdl.

This is ok. But the comment is just wrong. Can you send an updated
patch to RT?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "When C++ is your hammer, everything looks like a thumb."
    -- Steven M. Haflich