[Freeciv-Dev] Re: (PR#2413) ai diplomacy patch

["jorneg@xxxxxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>]

    I just wanna comment two this:

    - when you cancel an alliance with an ai, it seems that the code 
does not transfer you units from its cities. So in the next turn you get 
an assert.

    - I think that when a civilitation splits throught civil war, the 
new ai player does not get an inicialized ai.diplomacy structure, so is 
likely to crash when ai_evaluate_* in diplomacy.c executes. Any way, 
i've unavable to find the rutine that inicializes that struct. In 
server_player_init() is not...

    Any way, i'll look it in the new patch code.

En/na Per I. Mathisen via RT ha escrit:

>This is a new version of the AI diplomacy patch. Thanks a lot to Jordi for
>finding bugs and thus encouraging me to work on this patch again :-)
>
>There are lots and lots of changes. Most importantly, the AI will now
>suggest treaties to you through the diplomacy dialog, and AIs will make
>treaties with each other.
>
>I am not sure if this patch will work with gtk2 anymore. There were some
>big changes there that screwed my diff and I didn't see immediately how to
>fix it, but it might work somehow still...
>
>Even if you don't have time to review it properly, or even test it, please
>take time to skim over it and comment on the overall design, please.
>
>  - Per
>
>  
>