[Freeciv-Dev] Re: new patch: autoattack

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Fri, 22 Nov 2002, Jason Dorje Short wrote:
> This will not get us to attack diplomats or other near-helpless units
> that we may want to attack. So perhaps
>
>  if (penemywin > 1.0 - punitwin || penemywin > 0.99) {
>    /* ...autoattack... */
>  }

Note that it is actually rare that we have such good odds, even against
diplomats. And if we lower the threshold we may make bad decisions. So I
am not sure which is best, but after some consideration, I ended up with

   if (penemywin > 1.0 - punitwin || unit_flag(punit, F_DIPLOMAT))

which doesn't attack explorers and always attacks diplomat flag
units, even if they are (in a modpack) giant hulks, since this kept
things nice and simple. Modpackers shouldn't make the incredible hulk
diplomats anyway...

New patch attached.

  - Per

autoattack4.diff
Description: Text document