[Freeciv-Dev] (PR#2333) Add function die()

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

The patch replaces code like below:

     if (team_id == TEAM_NONE) {
-      freelog(LOG_ERROR, "Impossible: Too many teams!");
-      assert(FALSE);
-      exit(EXIT_FAILURE);
+      die("Impossible: Too many teams!");
     }

with 
+  vreal_freelog(LOG_FATAL, format, ap);
+  assert(FALSE);
+  exit(EXIT_FAILURE);

It simplifies the code (no longer the questions "is it LOG_ERROR or
LOG_FATAL" "exit or abort"). And it removes one dependency for
stdlib.h.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"

die1.diff.gz
Description: die1.diff.gz