[Freeciv-Dev] (PR#2267) Bug in ai_manage_military?

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

The attached patch removed the unconditional
handle_unit_activity_request(punit, ACTIVITY_IDLE) call in
ai_manage_military. We don't want to go idle for two reasons:

 - reduce bandwidth: the unit will be set here:
      if (unit_list_find(&(map_get_tile(punit->x, punit->y)->units),
          punit->ai.ferryboat))
        handle_unit_activity_request(punit, ACTIVITY_SENTRY);
      else
        handle_unit_activity_request(punit, ACTIVITY_FORTIFYING);
   to ACTIVITY_FORTIFYING and so the activity is switching between
   ACTIVITY_FORTIFYING and ACTIVITY_IDLE causing unnecessary transfers
   with the new delta protocol.

 - it may even improve the AI if the AI won't unconditional wake
 fortified units.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  reality.sys corrupt. Reboot Universe? (y,n,q)