[Freeciv-Dev] behavior of notify_embassies (PR#2153)

[nightmare@xxxxxxxxxx]

Full_Name: Davide Pagnin
Version: 1.13.1-devel
Distribution: Built from source
Client: Both (or N/A)
OS: 
Submission from: (NULL) (193.205.82.100)


On July 20, behavior of player_has_embassy has been changed.

This function now returns TRUE, in the case we ask if a player has
an embassy with himself.

This can be arguable, but this is not the point of this report.

The behavior change of player_has_embassy, does impact on the behavior
of notify_embassies function.

This function is called in:
server/cityturn.c
server/diplhand.c
server/diplomats.c
server/plrhand.c
server/unittools.c

And all that calls have their behavior modified by the player_has_embassy
behavior change.

I'm not sure that all of those behavior changes are wanted, at least one
such case is wrong (IMHO)

If you look into unittools.c notify_embassies call, you'll found that
a player will get 2 notification from getting a tech from a hut.