[Freeciv-Dev] Re: [Patch] Change MAPSTEP macro (PR#2123)

[rf13@xxxxxxxxxxxxxxxxx]

On Fri, Oct 04, 2002 at 01:05:57PM +0100, Gregory Berkolaiko wrote:
> On Fri, 4 Oct 2002 rf13@xxxxxxxxxxxxxxxxx wrote:
> 
> > On Tue, Oct 01, 2002 at 02:35:25PM -0500, Jason Short wrote:
> > > Raimar, I'd like to apply this change - it makes using it the way Greg 
> > > wants to much easier.
> > > 
> > > But, having MAPSTEP be a wrapper for DIRSTEP was your plan, and I won't 
> > > undo that without your approval.
> > 
> > The current form of MAPSTEP is ok for iterating around a common
> > center. Gregory will probably use it to update the destination
> > position if he goes along a precomputed path.
> > 
> > If DIRSTEP would have checks (which it doesn't have) I would said
> > no. Now I say that I think that the current code is clean and that I
> > also understand Gregory need.
> 
> Presumably that means you don't object to the change.

Yes.

> I will just add an explaining comment to the patch and resubmit it.

something like: "we should use DIRSTEP here BUT we also want to use src
as dest so we do a direct access to the DIR_* arrays." would do the job.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx