Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2002:
[Freeciv-Dev] Re: [Patch] Change MAPSTEP macro (PR#2123)
Home

[Freeciv-Dev] Re: [Patch] Change MAPSTEP macro (PR#2123)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxx
Cc: Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>, <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [Patch] Change MAPSTEP macro (PR#2123)
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 4 Oct 2002 13:05:57 +0100 (BST)

On Fri, 4 Oct 2002 rf13@xxxxxxxxxxxxxxxxx wrote:

> On Tue, Oct 01, 2002 at 02:35:25PM -0500, Jason Short wrote:
> > Raimar, I'd like to apply this change - it makes using it the way Greg 
> > wants to much easier.
> > 
> > But, having MAPSTEP be a wrapper for DIRSTEP was your plan, and I won't 
> > undo that without your approval.
> 
> The current form of MAPSTEP is ok for iterating around a common
> center. Gregory will probably use it to update the destination
> position if he goes along a precomputed path.
> 
> If DIRSTEP would have checks (which it doesn't have) I would said
> no. Now I say that I think that the current code is clean and that I
> also understand Gregory need.

Presumably that means you don't object to the change.

I will just add an explaining comment to the patch and resubmit it.

G.




[Prev in Thread] Current Thread [Next in Thread]