[Freeciv-Dev] Re: closing dialog windows on server disconnect (PR#533)

[rf13@xxxxxxxxxxxxxxxxx]

On Thu, Oct 03, 2002 at 10:30:49AM -0700, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> When the client disconnects (or is disconnected) from the server, many 
> dialog windows are not closed.  This is clearly Wrong, and can lead to 
> segfaults - particularly in the case of the city report dialog.
> 
> The dialogs that aren't closed include everything from the reports 
> dialog.  (Some of these are modal dialogs, so you can't *manually* 
> disconnect while they're open.)  Additionally some dialogs aren't 
> correctly updated if you disconnect and connect to a different game (for 
> instance the players dialog won't be updated until you close it).
> 
> The attached patch fixes this for the city dialog only.  It adds a new 
> GUI function, popdown_city_report_dialog, implements this for the stub, 
> gtk, gtk-2.0, xaw, and (untested) win32 GUIs.  The function is called on 
> server disconnect.  It will, unfortunately, break compilation of the 
> other guis (i.e. mui).

> Is this the correct fix?  Should a similar thing be done for the other 
> dialogs?

Yes. Yes. See my old popdown patch:
13569 Mar 19  2002 open/popdown1.diff 

Because of some non-hard problems with win32 it didn't got applied.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx