[Freeciv-Dev] "manual turn done in ai mode" doesn't work (PR#2121)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

The client has an option "Manual Turn Done in AI Mode".  When deselected 
(it is enabled by default) it is supposed to automatically end the turn 
ASAP when you're playing an AI player.
Currently, this feature does not work.  In fact, disabling the option 
will tend to confuse the turn done button completely, so that you cannot 
click on it at all.
I have traced the problem into send_turn_done() in civclient.c.  Here, 
get_turn_done_button_state returns TRUE, and agents_busy() also return 
TRUE, so the turn done packet never actually gets sent.  Instead, the 
client just sits around forever waiting for the agents to complete their 
tasks (but there does not appear to be a notification if they do so).
This could be related to PR#1962.

jason