[Freeciv-Dev] Make client aware of eng game status, related to (PR#1883)

[Davide Pagnin <nightmare@xxxxxxxxxx>]

        Hi all!

This is a work in progress patch.

The original goal of the patch was to fix the bug #1883, also known as
"DONT GET MAP AT ENDGAME".

The problem is that the client don't handle properly the condition when
the game has ended, and consider this state as running game.

This condition end up in a bunch of related problem, that need a proper
fix.

This patch, although incomplete, is a step toward the solution.

I hope...

The patch introduces 2 new function:

can_client_issue_orders
can_client_change_view

The names can obviously be changed is something more meaningful.

A client that can issue order, is a client that is not an observer and
that is connected to a game that is running, and for which giving or
changing orders make sense

A client that can change view, is a client that is connected to a game
for which map handling make sense (thus observer or not, game already
started but also ended)

The patch was started by me, then handled by Raimar, and then back to
me, thus is somewhat miscellaneous.

The gtk client is the only one that can be considered nearly finished,
because I want some feedback.

To have a sensible look on what this patch do, you can take every
savegame and set a proper endyear to come to the end game status
immediately. (More advanced is the game, better look on all aspect can
be done)

I've said this patch is unfinished, also for the gtk client, because I
want to handle, in a better way, the city dialog, it doesn't make sense
that you can sell or buy or whatever with an observer client nor an
ended game. 
I should also eliminate the focus on the last units, that is displayed
on the screen, even if you can't do anything.

Comment and suggestion, are strongly encouraged!!! (Please!!)

        Ciao, Davide

end_game_state.patch
Description: Text Data