[Freeciv-Dev] Re: fix for esd audio plugin

[rf13@xxxxxxxxxxxxxxxxx]

On Wed, Sep 25, 2002 at 10:15:20AM +0000, Per I. Mathisen wrote:
> This fixes a complaint Christian came up with a while ago regarding the
> esd audio plugin: Occasionally, when used with units that are moved on
> rail or moved off-screen on goto, you get a machine gun like series of
> sounds being played, because they play too fast. This patch solves
> this.

> This isn't a problem with the sdl plugin, so I didn't solve this for the
> general case (ie in audio.c), but maybe I should do that if this is also a
> problem for the Windows sound plugin?

IMHO this should be audio.c. Even if there are no problems with the
current set of other plugins.

> +    (void) gettimeofday(&tv, &tz); /* error unthinkable */

unthinkable? IMHO this should be an assert.

> +    if (abs(tv.tv_usec - time_last_path) < 45000

This looks wrong. You should also compare tv_sec.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx