[Freeciv-Dev] Re: cityrepdata.c i18n (PR#2043)

[Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Mateusz Stefek wrote:
> This patch replaces confusing N_("Sz") with N_("?size:Sz"),
> N_("n") with N_("?trade_routes:n"),
> N_("Pol") with N_("?pollution:Pol")
>
> So you have to translate title1 and title2 with Q_()
>
> In Polish and Russian we use two words for 'name'
> 'nazwa' is for things (cities), 'imie' is for persons (players).
> So this patch does not mean only cleaner i18n, but it also solves
> this problem (N_("Name") -> N_("?city:Name")).
The underlying change seems like a very good one - it will make the 
strings far more translatable.
However, two questions:

Do you think these qualifiers are the best possible?  i.e. instead of 
"?happy,content,unhappy,angry:H/C/U/A" I would think 
"?happy/content/unhappy/angry:H/C/U/A" would be better.  This is a 
fairly small issue, as the texts themselves are only a small part of the 
 patch (and easily changed later).
Coders (especially Raimar) - with this change, Q_ ends up being used all 
over the place - 2-3 times in each GUI, and it'll probably get called 
fairly often.  Although the overhead of such a call isn't high, it could 
be avoided if the string were translated once, when the client starts 
up, in just one place in the GUI-independent client code.  I know this 
sort of thing is used elsewhere (typically in menus and the like). 
Would it be a good idea here?
jason