[Freeciv-Dev] client core

["Per I. Mathisen" <per@xxxxxxxxxxx>]

Join savegame as Hatshepsut, attack the carrier in the south with all you
got. When it sinks, you core. Not sure where the bug is, but punit is not
found and the find_unit_by_id() which should pass a valid punit structure
to the agent passes a NULL. The attached patch fixes the symptom and
prevents further cores.

Yours
Per

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 1024 (LWP 462)]
0x080ed4a2 in unit_owner (punit=0x0) at unit.c:1011
1011      return (&game.players[punit->owner]);
(gdb) bt
#0  0x080ed4a2 in unit_owner (punit=0x0) at unit.c:1011
#1  0x080f232d in agents_unit_remove (punit=0x0) at agents.c:476
#2  0x08071db2 in handle_remove_unit (packet=0x831bb18) at packhand.c:175
#3  0x08062c20 in handle_packet_input (packet=0x831bb18, type=32)
    at civclient.c:308
#4  0x08067353 in input_from_server (fd=18) at clinet.c:325
#5  0x080a4392 in get_net_input (data=0x0, fid=18,
condition=GDK_INPUT_READ)
    at gui_main.c:1060
#6  0x4019b0de in gdk_get_show_events () from /usr/lib/libgdk-1.2.so.0
#7  0x401cac40 in g_io_add_watch () from /usr/lib/libglib-1.2.so.0
#8  0x401cc309 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#9  0x401cc913 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#10 0x401ccaac in g_main_run () from /usr/lib/libglib-1.2.so.0
#11 0x400e0e37 in gtk_main () from /usr/lib/libgtk-1.2.so.0
#12 0x080a3e2b in ui_main (argc=1, argv=0xbffffad4) at gui_main.c:897
#13 0x08062aa6 in main (argc=1, argv=0xbffffad4) at civclient.c:231


"I don't see why people are so upset about cloning sheep. American
television networks have been doing that to their audiences for years."
-- Jello Biafra

unittest.sav.gz
Description: application/gunzip

agentscorefix.diff
Description: Text document