[Freeciv-Dev] Re: debian package creating fails for 1.13.0 (PR#1938)

[Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Kurt Yoder wrote:
> Hello list
>
> I'm trying to build my own debian package out of the freeciv 1.13.0 I 
> downloaded. I followed the instructions in debian/INSTALL.debian up to the 
> point where it says to run "fakeroot build.debian":
> kyoder@bean:~/download/freeciv/freeciv-1.13.0$ fakeroot build.debian
> sh: build.debian: command not found
>
>
>
>
> OK, I figured it doesn't know where it is, since it's in the debian 
> subdirectory. So I try it with "fakeroot debian/build.debian" (previous 
> attempts at building this already built everything, that's why the following 
> is so short):
> kyoder@bean:~/download/freeciv/freeciv-1.13.0$ fakeroot debian/build.debian
>
> Now let's build it...
>
> dh_testdir
> dh_testroot
> dh_installdocs -pfreeciv
> cp: cannot stat `README.AI': No such file or directory
> dh_installdocs: command returned error code
> make: *** [binary-arch] Error 1
>
>
>
> So I did "ln -s doc/README.AI ." and ran "fakeroot debian/build.debian" 
> again. It gets past first error and complains about not being able to find 
> "HOWTOPLAY". So I symlink to doc/HOWTOPLAY and try again. This time it seems 
> to work and generates the .debs. Maybe someone needs to update the debian 
> subdirectory and debian/INSTALL.debian so that it all works correctly?
Yeah, these are bugs in the debian package generator - most of the docs 
have been moved into doc/, and need to be change in the debian/ 
directory.  There are also new documents.
I've never worked with debian package building before, unfortunately. 
Attached is a patch that accomplishes enough to get the package to build.
However, there are problems.

1.  I don't understand the handling of debian/docs.  Currently 
everything listed there gets include in the freeciv package (the server 
package), but not in freeciv-gtk or freeciv-xaw.  Before, the HOWTOPLAY 
file was (only) included for the client packages by adding it on the 
command line.  With more files now, I'd say new files should be created 
- freeciv.docs, freeciv-gtk.docs, freeciv-xaw.docs.
2.  There are no dependencies or checks for sound.  I'd say the default 
build should contain SDL support.  Eventually this could perhaps be a 
command-line option.
Also, I think the packages are misnamed.  Currently there are "freeciv", 
"freeciv-xaw3d", and "freeciv-gtk".  Well, for one thing we'll need a 
"freeciv-gtk2" package shortly.  But also "freeciv" is misnomer.  This 
package should be called "freeciv-server", and a dummy package "freeciv" 
should exist which requires freeciv-server and one of the freeciv-* 
clients (assuming this is possible).  This will become especially 
important once the client is able to automatically launch the server - 
then the average user should be able to get by with just an "apt-get 
install freeciv" that installs both client and server, and he won't have 
to worry about the separation at all.
Jules Bean, are you reading this?  Are you still maintaining debian/? 
Does any of what I say above seem feasible?
jason

Index: debian/INSTALL.debian
===================================================================
RCS file: /home/freeciv/CVS/freeciv/debian/INSTALL.debian,v
retrieving revision 1.1
diff -u -r1.1 INSTALL.debian
--- debian/INSTALL.debian       2002/04/11 10:14:03     1.1
+++ debian/INSTALL.debian       2002/08/19 06:19:15
@@ -53,7 +53,7 @@
 $ cd /somewhere/freeciv
 $ export EMAIL="Your Name <address@xxxxxxxx>"
 $ make distclean
-$ fakeroot build.debian
+$ fakeroot debian/build.debian
 $ su
 # dpkg -i ../freeciv_1.11.5+cvs20010419_i386.deb
 # exit
Index: debian/docs
===================================================================
RCS file: /home/freeciv/CVS/freeciv/debian/docs,v
retrieving revision 1.2
diff -u -r1.2 docs
--- debian/docs 2001/12/11 16:16:46     1.2
+++ debian/docs 2002/08/19 06:19:15
@@ -1 +1,12 @@
-ChangeLog NEWS README README.AI
+ChangeLog CHANGES
+NEWS
+
+doc/HOWTOPLAY
+doc/PEOPLE
+doc/README
+doc/README.AI
+doc/README.cma
+doc/README.graphics
+doc/README.rulesets
+doc/README.sound
+doc/TODO
Index: debian/rules
===================================================================
RCS file: /home/freeciv/CVS/freeciv/debian/rules,v
retrieving revision 1.11
diff -u -r1.11 rules
--- debian/rules        2001/06/30 13:52:27     1.11
+++ debian/rules        2002/08/19 06:19:15
@@ -19,20 +19,19 @@
        dh_testdir
 
        mkdir build-base
-       (cd build-base; ../configure $(COMMON_CONFIG) --disable-client; $(MAKE))
+       (cd build-base; ../configure $(COMMON_CONFIG) --disable-client && 
$(MAKE))
 
 build-xaw3d:
        dh_testdir
 
        mkdir build-xaw3d
-       (cd build-xaw3d;        \
-        ../configure $(COMMON_CONFIG) --disable-server --with-xaw3d; $(MAKE))
+       (cd build-xaw3d && ../configure $(COMMON_CONFIG) --disable-server 
--with-xaw3d && $(MAKE))
 
 build-gtk:
        dh_testdir
 
        mkdir build-gtk
-       (cd build-gtk; ../configure $(COMMON_CONFIG) --disable-server; $(MAKE))
+       (cd build-gtk && ../configure $(COMMON_CONFIG) --disable-server && 
$(MAKE))
 
 clean:
        dh_testdir
@@ -81,7 +80,7 @@
        dh_testdir
        dh_testroot
        dh_installdocs -pfreeciv
-       dh_installdocs -a HOWTOPLAY
+       dh_installdocs
 #      ln -fs freeciv debian/freeciv-xaw/usr/doc/freeciv-xaw
 #      ln -fs freeciv debian/freeciv-xaw3d/usr/doc/freeciv-xaw3d
 #      ln -fs freeciv debian/freeciv-gtk/usr/doc/freeciv-gtk