[Freeciv-Dev] Re: CMA crash after game load (PR#1920)

[Christian Knoke <chrisk@xxxxxxxx>]

[feeding into jitterbug]

----- Forwarded message from Raimar Falke <rf13@xxxxxxxxxxxxxxxxx> -----

From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Sun, 11 Aug 2002 12:49:16 +0200
To: Freeciv Developers <freeciv-dev@xxxxxxxxxxx>
Cc: "Per I. Mathisen" <Per.Inge.Mathisen@xxxxxxxxxxx>,
   Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: CMA crash after game load

On Sat, Aug 10, 2002 at 08:12:25PM +0200, Christian Knoke wrote:
> [since bugs@xxxxxxxxxxxxxxxxxxx refuses my mail, I'll file it later]
> 
> CVS 10 AUG 2002 unpatched Gtk+ 1.2
> 
> start civserver
> login chris
> 
> > load cma-load-crash.sav.gz
> > start
> 
> chris@max:~> civclient -t trident -P none
> 2: lost connection to server
> 1: ASV: München hat sich mehrfach geändert. Dies könnte an einem Fehler in
> Freeciv liegen: Bitte informieren Sie <freeciv-dev@xxxxxxxxxxx>. Die ASV für
> diese Stadt wird deshalb jetzt abgeschaltet.
> civclient: cma_core.c:1795: handle_city: Zusicherung »0« nicht erfüllt.
> Abgebrochen (core dumped)
> 
> There are more savegames for this.
> 
> http://www.enter.de/~c.knoke/bugs/cma-load-crash.sav.gz

I strongly think this is related to:

  This is an automated notification of a change to freeciv cvs,
  on Tue Aug  6 15:26:59 PDT 2002 = Tue Aug  6 22:26:59 2002 (GMT)
  by Per I. Mathisen <per@xxxxxxxxxxx>

  ---- Files affected:

  freeciv/client civclient.c
  freeciv/common game.c map.c nation.c nation.h
  freeciv/server mapgen.c plrhand.c plrhand.h savegame.c sernet.c srv_main.c 
stdinhand.c stdinhand.h

  ---- Log message:

  Add a "load" savegame command to civserver, and also squish a few memory
  leaks.

  Patch by Mike Kaufman <kaufman@xxxxxxxxxxxxxxxxxxxxxx>

Let Mike or Per find a fix which satisfy the attached condition.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Programming today is a race between software engineers striving to
  build bigger and better idiot-proof programs, and the Universe trying
  to produce bigger and better idiots. So far, the Universe is winning."
    -- Rich Cook

Index: common/packets.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/packets.c,v
retrieving revision 1.212
diff -u -r1.212 packets.c
--- common/packets.c    2002/08/10 17:07:24     1.212
+++ common/packets.c    2002/08/11 10:43:32
@@ -206,6 +206,11 @@
 
   freelog(LOG_DEBUG, "sending packet type=%d len=%d", data[2], len);
 
+  if (pc->player && is_server) {
+    assert(conn_list_size(&pc->player->connections) > 0
+          && pc->player->is_connected);
+  }
+
   if (!is_server) {
     pc->client.last_request_id_used =
        get_next_request_id(pc->client.last_request_id_used);


----- End forwarded message -----

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.