[Freeciv-Dev] Re: [FreeCiv-Cvs] per: Change player_has_embassy to return TRUE also i... (PR#1862)

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Wed, 31 Jul 2002, Christian Knoke wrote:
> > > Change player_has_embassy to return TRUEalso if we check ourselves,
> > > to mimic the behaviour of the other treaty check functions and basic
> > > sanity. Taken from active ai diplomats patch by me and Gregory.
> >
> > This patch has some silly consequences which I'm not sure we really want:
> >
> > in F3 dialog: you can show Intelligence of your own nation

This is a feature, IMHO.

> >             you can have conference with yourself, but since
> >             you have no partner to conclude, you have to cancel
> >             to close the dialog

This is a bug.

> > in F11 dialog: after the rang shown you get the info which nation is best.
> >              Now, if you are first, your own nation is displayed here,
> >              repeating the info; confusing

This also a bug. Thanks for finding them.

I didn't check the client for uses of this function before committing. mea
culpa. Patch will be forthcoming once I return to my freeciv box.

Yours
Per