[Freeciv-Dev] CMA failed assertion caused by Freight (PR#1684)

[kenn@xxxxxxxxxxxxxx]

Full_Name: Kenn Munro
Version: 1.12.7-devel
Distribution: Built from source
Client: Gtk+
OS: Red Hat 7.2
Submission from: (NULL) (216.104.96.132)


When moving a freight into one of my own cities, I get the message:

1: CMA: Tampere has changed multiple times. This may be an error in freeciv or
bad luck. Please contact <freeciv-dev@xxxxxxxxxxx>. The CMA will detach itself
from the city now.
civclient: cma_core.c:1795: handle_city: Assertion `0' failed.
Aborted (core dumped)

I've uploaded a savegame (kenn12.sav.gz) to incoming.  Join as kenn, then move
the freight from Zephath to Tampere.

Zephath had produced a number of freights in previous turns, which were used for
trade routes.  Some of those freights had also been assigned to different home
cities.

Backtrace:

(gdb) bt
#0  0x40339901 in __kill () at __kill:-1
#1  0x4033967d in raise (sig=6) at ../sysdeps/posix/raise.c:27
#2  0x4033ace8 in abort () at ../sysdeps/generic/abort.c:88
#3  0x40332d81 in __assert_fail (assertion=0x80d3af1 "0", 
    file=0x80d5eb3 "cma_core.c", line=1795, function=0x80d60e9 "handle_city")
    at assert.c:74
#4  0x080c4a41 in handle_city (pcity=0x833be28) at cma_core.c:1795
#5  0x080c1fbc in execute_call (call=0x6) at agents.c:198
#6  0x080c2030 in call_handle_methods () at agents.c:232
#7  0x0806e36c in handle_processing_finished () at packhand.c:2312
#8  0x080604af in handle_packet_input (packet=0x8319570, type=0)
    at civclient.c:430
#9  0x080634bf in input_from_server (fd=6) at clinet.c:325
#10 0x40186e7d in gdk_io_invoke (source=0x82c5bc0, condition=G_IO_IN, 
    data=0x82a0068) at gdkevents.c:882
#11 0x401b6a7a in g_io_unix_dispatch (source_data=0x82f0e00, 
    current_time=0xbffff890, user_data=0x82a0068) at giounix.c:137
#12 0x401b8055 in g_main_dispatch (dispatch_time=0xbffff890) at gmain.c:656
#13 0x401b8659 in g_main_iterate (block=1, dispatch=1) at gmain.c:877
#14 0x401b87e8 in g_main_run (loop=0x82ef930) at gmain.c:935
#15 0x400d42ab in gtk_main () at gtkmain.c:524
#16 0x0808cd50 in ui_main (argc=3, argv=0xbffff9e4) at gui_main.c:893
#17 0x080600e7 in main (argc=3, argv=0xbffff9e4) at civclient.c:216
---Type <return> to continue, or q <return> to quit---
#18 0x40327316 in __libc_start_main (main=0x805ff3c <main>, argc=3, 
    ubp_av=0xbffff9e4, init=0x805d150 <_init>, fini=0x80c5680 <_fini>, 
    rtld_fini=0x4000d2fc <_dl_fini>, stack_end=0xbffff9dc)
    at ../sysdeps/generic/libc-start.c:129

Kenn