[Freeciv-Dev] Re: tradesize variables (PR#1488)

[Per I Mathisen <per@xxxxxxxxxxx>]

On Wed, 22 May 2002, Christian Knoke wrote:
> > set notradesize 3
> > set fulltradesize 5
>
> The first statement is rejected with an error message,
> because notradesize > fulltradesize. You don't expect this,
> it is the only interdepency between variable assignments.
>
> I suggest, just allow the first statement, and give fulltradesize
> dominance, that is, if notradesize > fulltradesize, just ignore
> notradesize. Change the help text to reflect this.

This is hard to fix because of the rigid way the options are parsed. The
simplest way to fix it would be to unify the above into one command which
takes two arguments

        tradesize <notrade> <fulltrade>

Is this an okay solution?

In any case, I do not think this is a release critical bug. It is merely a
bit annoying for those who want to use it, the first time. And hardly
anyone will try it anyway.

> Also note, if you issue the two statements above, and then:
>
> > write setting
>
> restart civserver, and:
>
> > read setting
>
> the result is:
>
> notradesize   +=0
> fulltradesize + 5
>
> which is faulty.

Why? Looks alright to me.

Yours,
Per

"It is difficult to catch a black cat in a dark room.
Especially if there is no cat there." - Confucius