[Freeciv-Dev] Re: Clients can see supposedly invisible subs (PR#1405)

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Sat, May 18, 2002 at 06:25:59PM +0200, Raimar Falke wrote:
> Attached patch does:
>  - audit all city and unit related handle methods (no error was
>  found). So the hole mentioned in (PR#80) is closed.
>  - changed all city and unit related handle methods to follow the same
>  style. Remove stupid things like:
> 
>   struct unit *punit = player_find_unit_by_id(pplayer, req->unit_id);
> ...
>   if (unit_owner(punit) != pplayer) {
>     freelog(LOG_ERROR, "%s trying to paradrop a non-owner unit!\n",
>        pplayer->name);
>     return;
>   }
> 
>  - cleanup of is_hiding_unit and player_can_see_unit
>  - add a check for player_can_see_unit into send_unit_info_*

Updated patch attached:
 - remove the audit changes (already applied)
 - add a test for NULL pointer

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Sit, disk, sit. Good boy. Now spin up. Very good. Here's a netscape
  cookie for you. Fetch me some data. Come on, you can do it. No, not that
  data. Bad disk. Bad." 
    -- Calle Dybedahl, alt.sysadmin.recovery

invis2.diff
Description: Text document