[Freeciv-Dev] Re: Status of submitted patches

[Per I Mathisen <per@xxxxxxxxxxx>]

On Thu, 23 May 2002, Davide Pagnin wrote:
> 1) http://arch.freeciv.org/freeciv-dev-200205/msg00233.html
>
> (There is an important bugfix for the actual angrycitizen
> implementation, and the patch for the correct civ II behaviour
> for the specialists)
>
> Ross, stated that this patch may raise problem for the AI
> that has to reallocate theirs citizen, but he also said:
> "These are not showstopper issues, so they shouldn't hold
> up this patch. But they will do undesireable things on
> occasion until fixed."
>
> So, There is not Strong reject on the patch, or I'm getting
> something wrong?

If Raahul could look at the things Ross mentioned, test his changes
against this, and tell me that this isn't a problem, I will commit his
patch.

> 2) http://arch.freeciv.org/freeciv-dev-200205/msg00201.html
>
> (The luxury cap problem, at the moment there is no consensus
> to put a luxury cap into freeciv, unless it is a configurable
> option, thus I urge mainteners to say what has to be done,
> and how, and more important, if this effort can be introduced
> into 1.13.0 (aka bugfix) or not (aka new features).

This is a new feature, and it should be controlled by a ruleset option. It
won't get in 1.13.0 release. Sorry.

> Connected to this, there is a problema related to the happiness
> display, stating erroneously that the cap is enforced even
> if this is not true, which decision about this?

I don't remember this problem...

> 3) http://arch.freeciv.org/freeciv-dev-200205/msg00429.html
>
> (old readline support, proposed by me, reworked by Per and
> Raimar, a final word on this?)

I just committed it.

> 4) http://arch.freeciv.org/freeciv-dev-200205/msg00435.html
>
> (64bit architectures fixes, made by Raimar and reviewed by
> me, perhaps Ben may be another reviewer, and after the
> patch may be commited?)

No idea. Not my kind of stuff.

Yours,
Per

"As Israeli forces pursued militants, civilians
continued getting in the way and dying as a
result." -- New York Times, April 21