[Freeciv-Dev] gtk-theme (PR#1467)

[alfa003@xxxxxxxxxxx]

Full_Name: Magnus
Version: 1.12.0
Distribution: Built from source
Client: Gtk+
OS: solaris
Submission from: (NULL) (130.237.227.34)


When using freeciv.rc to theme the gtk-client , the turn_done_button
remains unchanged.
As far as I understand this is because the style is hardcoded into
the code.
In client/gui-gtk/gui_main.c , the line :

gtk_widget_set_style(turn_done_button,
gtk_style_copy(turn_done_button->style));

seems to prevent the user from overriding the values. I have tested
removing this line and the button takes on the theme values that case.

reproduction: tried to change the appearance of the turn_done_button
via freeciv.rc in the following way :

style "mycolor"
{

base[PRELIGHT] = { 0.1, 0.6, 0.6 }
base[ACTIVE] = { 0.1, 0.6, 0.6 }
base[NORMAL] = { 0.1, 0.6, 0.6 }
base[INSENSITIVE] = { 0.1, 0.6, 0.6 }

bg[PRELIGHT] = { 0.1, 0.6, 0.6 }
bg[ACTIVE] = { 0.1, 0.6, 0.6 }
bg[NORMAL] = { 0.1, 0.6, 0.6 }
bg[INSENSITIVE] = { 0.1, 0.6, 0.6 }

fg[PRELIGHT] = { 1.0, 1.0, 1.0 }
fg[ACTIVE] = { 1.0, 1.0, 1.0 }
fg[NORMAL] = { 1.0, 1.0, 1.0 }
fg[INSENSITIVE] = { 0.1, 0.4, 0.4 }

}
class   "*"                             style   "mycolor"
widget  "*"                             style   "mycolor"