[Freeciv-Dev] Re: Freecost Calculation (PR#1262)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Feb 12, 2002 at 10:59:14AM -0800, Christian Knoke wrote:
> > CVS 12 FEB 2002
> > 
> > After set freecost 20, when I have research = 0/10 and
> > move into a hut and get a tech for free, then research
> > is set to -4/20 instead of -2/20 IMHO. Obviously it is
> > calculated from the next search goal (=20) instead of from 
> > the actual search goal (=10).
> > 
> > This is unfair (tm). Starting with 9/10, and freecost=100,
> > a free tech ends up in -11/20, which means a penalty
> > of 145 % (not tested, though)
> 
> Attached is the fix which move all free cost reduction in front of the
> get_new_tech calls. It is tested.

You missed a few other cases where you obtain free techs. The Great Library

http://www.freeciv.org/lxr/source/server/plrhand.c?v=cvs#L139

Darwins 

http://www.freeciv.org/lxr/source/server/cityturn.c?v=cvs#L977

If you would prefer not to get new emails from Christian complaining about free
techs from Darwin/Library, fix this two other cases.

Aloha,
RK.

We have a criminal jury system which is superior to any in the world; and its
efficiency is only marred by the difficulty of finding twelve men every day who
don't know anything and can't read. -Mark Twain

__________________________________________________
Do You Yahoo!?
Yahoo! Shopping - Mother's Day is May 12th!
http://shopping.yahoo.com