[Freeciv-Dev] Re: [PATCH] Customizable default ruleset

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, May 03, 2002 at 06:51:29PM -0400, Baumans wrote:
> This patch allows you to customize what your default ruleset is by adding a
> 'tileset="whatever"' to the "[client]" section of your .civclientrc .

The idea of the patch is ok. The patch itself:

> +char *d_tileset;

Does "d" for default? If so please rename it to default_tileset.

> +  d_tileset = strdup(secfile_lookup_str_default(&sf,"","%s.tileset",prefix));

Why strdup?

> +extern char *d_tileset;

This is wrong. You have to declare the variable in civclient.h

> +  if (d_tileset == NULL) {
> +   printf("d_tileset null\n");

Replace printf with freelog().

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 1 + 1 = 3, for large values of 1