[Freeciv-Dev] Re: [Patch] Fix for 533

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Apr 10, 2002 at 09:14:19PM +0200, Andreas Kemnade wrote:
> Raimar Falke writes:
>  > On Tue, Mar 19, 2002 at 09:00:07PM +0100, Raimar Falke wrote:
>  > > 
>  > > The attached patch should fix the issue of open/533. I'm not sure if I
>  > > got all dialogs but the biggest ones.
>  > > 
>  > > Andreas: can you provide an updated version of the patch for win?
>  > > Vasco: can you do the same for GTK2.0?
>  > 
>  > Last chance to post any comments.
> Sorry, I have not seen your first mail. My INBOX file gots trashed at
> that time. VM(Xemacs) let's me only see the subject line. It does not
> look very important to me, so I did not search the mail in that file.
> 
> My idea is:
> Every client should have a popdown_everything() function.

Ok if this function is in addition to the seperate popdown_xyz
functions.

> It should be called before gui_server_connect 

Ack.

> In the gui-win32 client I would do something like this:
> void popdown_everything(void)
> {
>   iterate_through_dialogs {
>      close(dialog);
>   } iterate_through_dialogs_end;
> }

At least the GTK client has to call the various popdown_*
functions. There is no global iteration. Inless we add it.

> All dialogs in gui-win32 dialogs have destroy callbacks which will do
> the cleanup in such a case.

A typical popdown method in the GTK client looks like this:

+void popdown_city_report_dialog()
+{
+  if (city_dialog_shell) {
+    if (city_dialog_shell_is_modal) {
+      gtk_widget_set_sensitive(top_vbox, TRUE);
+    }
+    gtk_widget_destroy(city_dialog_shell);
+    city_dialog_shell = NULL;
+  }
+}

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "These download files are in Microsoft Word 6.0 format. After
  unzipping, these files can be viewed in any text editor, including
  all versions of Microsoft Word, WordPad, and Microsoft Word Viewer."
    -- http://www.microsoft.com/hwdev/pc99.htm