[Freeciv-Dev] Re: [IAMBACK] [PATCH] [1.3] cleanup of proccess_*_want() (PR#1295)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Petr Baudis <pasky@xxxxxxxxxxx> wrote:
> Dear diary, on Sun, Apr 07, 2002 at 03:17:26AM CEST, I got a letter,
> where Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
> +      if (unit_type_flag(unit_type, F_IGTER)) {
> +        /* Not quite right... */
> +        /* TODO: Use something like IGTER_MOVE_COST. -- Raahul */
> +        move_rate *= SINGLE_MOVE;
> +      }
> 
> +      if (unit_types[unit_type].move_type == LAND_MOVING) {
> +        if (boatspeed > 0) {
> +          /* It's either city or too far away, so don't bother with
> +           * victim_move_rate. */
> +          move_time = (warmap.cost[boatx][boaty] + move_rate - 1) /
> move_rate
> +                      + 1 + warmap.seacost[x][y] / boatspeed; /* kludge
> */
> +          if (unit_type_flag(unit_type, F_MARINES)) move_time -= 1;
> +          
> +        } else if (warmap.cost[x][y] <= move_rate) {
> +          /* It's adjacent. */
> +          move_time = 1;
> +
> +        } else {
> 
> 
> I'm everytime puzzled with those dramatical mysterious pauses.. like you
> wanted to say something, then changed your mind.. ;)

I didn't add those mysterious pauses. That not quite right bit is a Syelism.

<snip>

> > > All of my complaints are about your comments which is non-essential.
> > > I haven't checked line-by-line correspondence but if you run a few 
> > > autogames, I think the patch can be safely committed and human resources 
> > > directed to pastures new (like the dreaded and bugged f_s_t_k).
> > 
> > Not the f_s_t_k. Anything but that. What have I done to deserve this?
> 
> Muahahahaha >:).
> 
> Don't fear, we'll shield you..

I'm having flasbacks to 'Nam. This is cruel and unusual punishment. You are all
in violation of the Geneva Convention.

Crew: Should I send in Readme.AI minus Per's diplomacy bits today, or wait till
later?

Aloha,
RK.

__________________________________________________
Do You Yahoo!?
Yahoo! Tax Center - online filing with TurboTax
http://taxes.yahoo.com/