[Freeciv-Dev] Re: [Patch] Bool cleanup of client/

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Mar 15, 2002 at 06:41:02PM +0100, Per I. Mathisen wrote:
> On Fri, 15 Mar 2002, Raimar Falke wrote:
> >  - replaces gboolean with bool
> 
> Uh-huh, is this a good idea? If you define bool to a different size than
> the gnomes do, won't this possibly cause some very hard to find breakages?

But these places are conceptually "ours" and so we use "our" bool.

> > in common/shared.h to
> >   typedef char bool;
> 
> So you have settled on char for bool?

No. But it allows gcc to catch some of simple cases. 

> I think this is a bad idea. Modern CPUs don't like 8bit types much.

I have to run some long tests. Note that at least in my g++
installation the type bool has a size of 1 byte.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
    1) Customers cause problems.
    2) Marketing is trying to create more customers.
  Therefore:
    3) Marketing is evil.