[Freeciv-Dev] segfault when clicking 'Change' in Cities window (PR#1299)

[kimiko@xxxxxxxxx]

Full_Name: Kimiko Koopman
Version: 1.12.1-devel gui-gtk
Distribution: Built from source
Client: Gtk+
OS: Linux 2.4.17-0.18, RedHat RawHide, i686
Submission from: (NULL) (213.84.28.102)


Late in the game (I have Armor and Battleship), the client crashes when I click
the 'Change' button in the Cities window. I have had this bug since at least a
few weeks and it always occurs late in the game (tech-wise, I haven't conquered
a lot yet) and whether I have selected one or more cities. When I reconnect
after starting the client again, the same thing happens. When I save the game
from the server and restart both the server and the client, the bug still
occurs.

Here is some output from gdb:
>Program received signal SIGSEGV, Segmentation fault.
>0x080bc571 in get_unit_name (id=27) at unittype.c:223
>223        my_snprintf(buffer, sizeof(buffer),
>(gdb) bt
>#0  0x080bc571 in get_unit_name (id=27) at unittype.c:223
>#1  0x08060ef7 in name_and_sort_items (pcids=0xbfffe900, num_cids=14, 
>    items=0xbfff6c00, show_cost=1, pcity=0x0) at climisc.c:745
>#2  0x08079e46 in append_impr_or_unit_to_menu_sub (menu=0x834bb38, 
>    nothing_appended_text=0x80c864a "No Units Available", append_units=1, 
>    append_wonders=0, change_prod=1, 
>    test_func=0x8060cf4 <city_can_build_impr_or_unit>, 
>    callback=0x8079fb0 <select_impr_or_unit_callback>) at cityrep.c:221
>#3  0x0807a29f in append_impr_or_unit_to_menu (menu=0x834bb38, change_prod=1, 
>    append_improvements=1, append_units=1, 
>    test_func=0x8060cf4 <city_can_build_impr_or_unit>) at cityrep.c:306
>#4  0x0807aa1a in city_change_callback (w=0x825e2a8, event=0x8315dc8,
data=0x0)
>    at cityrep.c:512
>#5  0x400f98e6 in gtk_marshal_BOOL__POINTER () from /usr/lib/libgtk-1.2.so.0
>#6  0x40136835 in gtk_handlers_run () from /usr/lib/libgtk-1.2.so.0
>#7  0x401357be in gtk_signal_real_emit () from /usr/lib/libgtk-1.2.so.0
>#8  0x40132d8e in gtk_signal_emit () from /usr/lib/libgtk-1.2.so.0
>#9  0x401789d4 in gtk_widget_event () from /usr/lib/libgtk-1.2.so.0
>#10 0x400f96ef in gtk_propagate_event () from /usr/lib/libgtk-1.2.so.0
>#11 0x400f843c in gtk_main_do_event () from /usr/lib/libgtk-1.2.so.0
>#12 0x401c24f5 in gdk_event_dispatch () from /usr/lib/libgdk-1.2.so.0
>#13 0x401f8b90 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
>#14 0x401f90f2 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
>#15 0x401f9304 in g_main_run () from /usr/lib/libglib-1.2.so.0
>#16 0x400f7ede in gtk_main () from /usr/lib/libgtk-1.2.so.0
>#17 0x0808a349 in ui_main (argc=1, argv=0xbffff654) at gui_main.c:867
>#18 0x0805f0bc in main (argc=1, argv=0xbffff654) at civclient.c:194
>#19 0x4034c58a in __libc_start_main () from /lib/i686/libc.so.6