[Freeciv-Dev] Re: loading rulesets patch

[Reinier Post <rp@xxxxxxxxxx>]

On Sat, Mar 02, 2002 at 08:34:08PM +0100, Per I. Mathisen wrote:

> Well look at it from Johnny's perspective:
> 
> players_iterate(pplayer) {
>    patiently_explain_a_modpack_is_loaded_and_what_it_does(johnny,pplayer);
>    if (game.nplayers > MAX_AMOUNT_PATIENCE) {
>       tired_and_quitting(johnny);
>    }
> }

pplayer has no way to verify what Johnny is explaining.

> The entire point of this patch is to load rulesets _before_ pregame, so
> that we can use ruleset information _in_ pregame. So if we are to be able
> to change rulesets in pregame, we must reload. It is not a strawman, it is
> a real problem.

The Help menu can be enabled, for example.  That will also help novices
when playing with the default ruleset.

> > Conclusion: this feature has got to go back in. If you want to write a
> > warning into stdinhand for "help rulesetdir" about possible nastiness,
> > fine. fix the ruleset code later.
> 
> If you insist...

I think it should go.  If rulesets are verified to be correct (by running
a server on them and seeing if it crashes) and explained (I don't care
how, a web interface?) the option to select them at runtime makes sense.

-- 
Reinier