[Freeciv-Dev] Re: cleanup to id_to_info_row (PR#1292)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Raimar Falke wrote:
> On Sat, Mar 02, 2002 at 02:00:27AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> Is it possible to merge get_city_mapview_production,
> get_city_dialog_production, cr_entry_building and this proposed
> get_city_dialog_production_text?
It is surely possible, but I think the different parameters given to the 
functionals and conditionals within it would make the code almost as 
long, and much less readible.
What might be a good idea, though, is to place it all into one location. 
 Currently get_mapview_production is in mapview_common, 
get_city_dialog_production is in citydlg_common (along with the two 
other proposed functions), and cr_entry_building is in cityrepdata.
But, where would they go?

jason