[Freeciv-Dev] Re: don't show "999" as the city turns to build (PR#1283)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
<snip>
> >>The game shows "999" as the turns to build for production that will 
> >>never finish.  This has always annoyed me.  This patch corrects that for 
> >>the city descriptions in the mapview only.  (Thus, it consolidates code 
> >>overall.)  It also special-cases the "999" that is returned, and prints a 
> >>"-" in place of the number.  (I had originally put "never" here instead of 
> >>"-", but 
> >>CivIII uses "-" so I figure that's just as good.)
> >>
> >>I've made changes to all GUI's, but I've only tested GTK and XAW,
> naturally.
> >>
> >>Finally, note this only changes the mapview, not the city dialog.  These 
> >>are pretty much completely separate, and the city dialog will probably 
> >>be a bit more difficult since it varies between GUIs.
> >>
> > 
> > Very nice. However this 999 in city_turns_to_build should really be a
> > FC_INFINITY. This will also force us to have special handling
> > everywhere. Can you do that?
> 
> It's easy enough to change the 999's to FC_INFINITY, and makes things 
> better (much more readible).
> 
> The only problem is that it (kind of) forces us to have special handling 
> everywhere _in this patch_, since otherwise people will use "10...000 
> turns" everywhere, which just doesn't look good.
> 
> But, here's the patch without that.  It still just changes the mapview, 
> makes the FC_INIFINITY change, and fixes the typos pointed out for win32 
>   and mui (the same typo).
> 

Nice work. I'm looking forward to FC_INFINITY being made universal.



__________________________________________________
Do You Yahoo!?
Yahoo! Sports - Coverage of the 2002 Olympic Games
http://sports.yahoo.com