[Freeciv-Dev] Re: don't show "999" as the city turns to build (PR#1283)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 25, 2002 at 10:50:10AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> The attached patch is a rewrite of a patch I submitted about a year ago. 
>   It was more-or-less ignored at the time, but recently a friend 
> mentioned to me how much this bugged him as well, so I've brought it 
> back out.
> 
> The game shows "999" as the turns to build for production that will 
> never finish.  This has always annoyed me.  This patch corrects that for 
> the city descriptions in the mapview only.  It takes out all of the 
> identical code to assemble the mapview production description, and puts 
> that into a function get_city_mapview_production() in 
> mapview_common.[ch].  (Thus, it consolidates code overall.)  It also 
> special-cases the "999" that is returned, and prints a "-" in place of 
> the number.  (I had originally put "never" here instead of "-", but 
> CivIII uses "-" so I figure that's just as good.)
> 
> I've made changes to all GUI's, but I've only tested GTK and XAW, naturally.
> 
> Finally, note this only changes the mapview, not the city dialog.  These 
> are pretty much completely separate, and the city dialog will probably 
> be a bit more difficult since it varies between GUIs.

Very nice. However this 999 in city_turns_to_build should really be a
FC_INFINITY. This will also force us to have special handling
everywhere. Can you do that?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Real Users find the one combination of bizarre
   input values that shuts down the system for days."